Repository navigation
Re-implement template refactor - #14716
Merged
Merged
Conversation
MattGal
reviewed
Apr 17, 2024
missymessa
previously approved these changes
Apr 18, 2024
AlitzelMendez
previously approved these changes
Apr 18, 2024
Member
|
GOOD LUCK! |
…revert-template-revert
AlitzelMendez
previously approved these changes
Apr 18, 2024
epananth
previously approved these changes
Apr 18, 2024
AlitzelMendez
approved these changes
Apr 18, 2024
Member
|
looks like we'll need a third try :) |
Member
Author
let's not limit ourselves. jk, i understand why my validation failed, and i'm enlisting @epananth to perform validation as well. sorry for the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
This is the revert of this revert.
The first implementation failed because I didn't realize teams were making direct references to some of the post-build templates.
this change adds shims for those templates which were directly referenced and caused the publishing failure.
Validated the code path works with this arcade job. The job fails because i didn't configure the temporary channel i set up properly, but the desired code path is executed.
I'll do some more validation today / this weekend. I have no intention of merging this on a Friday afternoon.